Skip to content

refactor: use serde_urlencoded for query parameters - #18

Merged
sachiniyer merged 1 commit into
mainfrom
siyer/serde-urlencoded
Feb 13, 2026
Merged

sachiniyer merged 1 commit into
mainfrom
siyer/serde-urlencoded

Conversation

@sachiniyer

Copy link
Copy Markdown
Contributor

Replace manual url.query_pairs_mut().append_pair(...) pattern in
list_bugs and list_repos with typed query structs serialized via
serde_urlencoded. This makes the query parameter contract explicit
and type-checked, and removes the direct url crate dependency.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

sachiniyer commented Feb 13, 2026 •

Copy link
Copy Markdown
Contributor Author

@sachiniyer
sachiniyer force-pushed the siyer/serde-urlencoded branch from 2888b45 to ed98f75 Compare February 13, 2026 05:45
@sachiniyer
sachiniyer marked this pull request as ready for review February 13, 2026 05:47
@sachiniyer
sachiniyer force-pushed the siyer/unify-enums branch 2 times, most recently from da57c11 to 64c3fa4 Compare February 13, 2026 05:57
@sachiniyer
sachiniyer force-pushed the siyer/serde-urlencoded branch from ed98f75 to 3d257c4 Compare February 13, 2026 05:57
@sachiniyer
sachiniyer changed the base branch from siyer/unify-enums to graphite-base/18 February 13, 2026 06:01
Replace manual url.query_pairs_mut().append_pair(...) pattern in
list_bugs and list_repos with typed query structs serialized via
serde_urlencoded. This makes the query parameter contract explicit
and type-checked, and removes the direct url crate dependency.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sachiniyer
sachiniyer force-pushed the siyer/serde-urlencoded branch from 3d257c4 to d4116ea Compare February 13, 2026 06:01
@graphite-app
graphite-app Bot changed the base branch from graphite-base/18 to main February 13, 2026 06:02
@graphite-app

graphite-app Bot commented Feb 13, 2026 •

Copy link
Copy Markdown

Merge activity

  • Feb 13, 6:02 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Feb 13, 6:05 AM UTC: @sachiniyer merged this pull request with Graphite.

@sachiniyer
sachiniyer merged commit 69c50ce into main Feb 13, 2026
21 checks passed
@sachiniyer
sachiniyer deleted the siyer/serde-urlencoded branch February 13, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant