Added proxy flag for cli #3963
Open
Added proxy flag for cli #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -183,7 +184,7 @@ const runSingleRequest = async function ( | |||
| if (collectionProxyEnabled === true) { | |||
| proxyConfig = collectionProxyConfig; | |||
| proxyMode = 'on'; | |||
| } else { | |||
| } else if(proxy) { | |||
| // if the collection level proxy is not set, pick the system level proxy by default, to maintain backward compatibility | |||
There was a problem hiding this comment.
does this line make any sense now, what do we default to if the --proxy is not defined? @naman-bruno
|
LGTM |
sanish-bruno
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a
--proxyflag in the CLI to allow users to enable or disable the system proxy. By default, the system proxy is off, and adding the--proxyflag turns it on.Issue: Previously, when running any request in the CLI, the system proxy was always picked up, and the only way to disable it was by deleting the
https_proxyenvironment variables. This flag provides a more convenient way to control proxy usage.Contribution Checklist:
Screen.Recording.2025-02-07.at.12.03.26.PM.mov