Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow longer names in tab header #3385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samhoooo
Copy link
Contributor

Description

This PR aims to allow longer names in tab header to resolve:

image

Implementation details:

I updated css max-width: 250px of tab header to achieve longer name display

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • [x ] The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@samhoooo samhoooo changed the title Allow longer names in tab header feat: allow longer names in tab header Oct 29, 2024
@tlaloc911
Copy link
Contributor

I suggest to update calculations that determine if arrows in the tabs are shown "<" ">" too in order to mantain behavior consistent

packages\bruno-app\src\components\RequestTabs\index.js

const maxTablistWidth = screenWidth - leftSidebarWidth - 150;
const tabsWidth = collectionRequestTabs.length * 150 + 34; // 34: (+)icon

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants