Skip to content

Remove Environment::MAX_EVENT_TOPICS and remove Environment generic type from event abstractions #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 8, 2025
Merged

Remove Environment::MAX_EVENT_TOPICS and remove Environment generic type from event abstractions #2622

merged 7 commits into from
Sep 8, 2025

Conversation

davidsemakula
Copy link
Collaborator

@davidsemakula davidsemakula commented Sep 8, 2025 •
edited
Loading

Summary

Closes #2601
Follow up to #2580

  • [y] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on a specific version of cargo-contract or pallet-revive?

Description

See #2601 for details

Follow ups

Checklist before requesting a review

  • I have added an entry to CHANGELOG.md
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@davidsemakula davidsemakula mentioned this pull request Sep 8, 2025
Merged
5 tasks
cmichi
cmichi approved these changes Sep 8, 2025
View reviewed changes
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidsemakula davidsemakula force-pushed the semakula/remove-events-env-config branch from d056fa5 to a815369 Compare September 8, 2025 23:24
@davidsemakula davidsemakula merged commit aa8c0ca into master Sep 8, 2025
20 checks passed
@davidsemakula davidsemakula deleted the semakula/remove-events-env-config branch September 8, 2025 23:43
@davidsemakula davidsemakula mentioned this pull request Sep 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi cmichi approved these changes

@AlexD10S AlexD10S Awaiting requested review from AlexD10S AlexD10S is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Environment::MAX_EVENT_TOPICS and remove Environment generic type from event abstractions
2 participants
@davidsemakula @cmichi