-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MUST Sensor Driver #618
Merged
Merged
MUST Sensor Driver #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sensorId and projString from configuration
paulbourelly999
commented
Jun 21, 2024
paulbourelly999
commented
Jun 21, 2024
paulbourelly999
commented
Jun 21, 2024
paulbourelly999
commented
Jun 21, 2024
paulbourelly999
commented
Jun 21, 2024
paulbourelly999
commented
Jun 21, 2024
paulbourelly999
commented
Jun 21, 2024
paulbourelly999
commented
Jun 21, 2024
dan-du-car
reviewed
Jun 25, 2024
dan-du-car
reviewed
Jun 25, 2024
dan-du-car
reviewed
Jun 25, 2024
public: | ||
/** | ||
* @brief Constructor | ||
* @param name Plugin Name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this comment add any value.
src/v2i-hub/MUSTSensorDriverPlugin/test/TestMUSTSensorDetection.cpp
Outdated
Show resolved
Hide resolved
src/v2i-hub/MUSTSensorDriverPlugin/test/TestMUSTSensorDetection.cpp
Outdated
Show resolved
Hide resolved
dan-du-car
reviewed
Jun 27, 2024
Quality Gate failedFailed conditions |
dan-du-car
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
MUST Sensor Driver Plugin
Adding MUST Sensor Driver to V2X-Hub. Documentation on MUST Sensor Driver will be included in README. This new plugin is responsible for consuming UDP CSV (Comma Separated Values) string packets that represent detections from the MUST Sensor. These will be converted into SensorDetectedObject which can be forwarded to the CARMA Streets Sensor Data Sharing Service to create SDSMs (Sensor Data Sharing Messages).
Sensor Detected Object
This PR includes updates to the SensorDetectedObject TMX message including removing references to simulation since this message will no longer be exclusively used in simulation. This PR also includes adding fields and JSON serialization methods to the SensorDetectedObject. This was previously unnecessary since incoming messages from CDASim (our simulation environment) were already JSON strings and were just passed via payload.
UDP Server
This PR also includes updates to the UDPServer class in TMX Utils. It provides a method to directly consume string payloads from the UDPServer. Many users of the UDP Server have to write this logic when they use the UDP Server. Adding it to the class is in an effort to reduce duplication of this logic across V2X-Hub.
Future Improvements
This PR further highlights the needs to address/fix #561 which currently prevents from correct JSON serialization and deserialization of TMX messages and prevents defining messages with nested objects.
Related Issue
FCP-3 (Design)
FCP-4 (Implementation)
Motivation and Context
Freight Cooperative Perception
How Has This Been Tested?
Unit testing and script based integration testing. For instructions for script based integration testing refer to Functionality Testing section of the README document.
Types of changes
Checklist:
V2XHUB Contributing Guide