Remove dependency on urllib3 #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in `urllib3:2.0` made the parts we use private methods. this means we should not have been using those and that we were incompatible with v2. Replacing it with `urllib.parse` as a dependency gives us the same results but with one less library to be compatible with.
rdohms
force-pushed
the
task/urllib3
branch
2 times, most recently
from
bb40762 to
d09e8c5
Compare
Transitioning to maintenance mode means we have less people working on this, adding automated tests will help avoid problems.
|
Split this into other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our usage is incompatible with
urllib3:v2and can be catered byurllib.Closes #28