Raise bad response status code #12
Conversation
| @@ -72,11 +72,11 @@ class APIClient(object): | |||
| """ | |||
|
|
|||
| resources = { | |||
| 'scopes' : { | |||
| 'scopes': { | |||
There was a problem hiding this comment.
These are just whitespace differences to comply with PEP8.
There was a problem hiding this comment.
Thanks for your interest in this repository and for your invested time.
Next to one minor comment on your changes, I would like to see the tests pass again. Can you have a look into that?
See: https://travis-ci.org/usabilla/api-python/jobs/353342188
usabilla.py
Outdated
| @@ -300,20 +297,16 @@ def item_iterator(self, url): | |||
|
|
|||
| :type url: str | |||
|
|
|||
| :returns: An `generator` that yeilds the requested data. | |||
| :returns: A `generator` that yeilds the requested data. | |||
There was a problem hiding this comment.
Here, there's a typo in yields too.
Also this comment/docstring needs an addition, since the method now can also raise an HTTPError.
|
@tzengerink np, I should've checked that. They should pass now. |
tests.py
Outdated
| import usabilla as ub | ||
|
|
||
| from mock import Mock | ||
| import requests |
There was a problem hiding this comment.
I'd like to see the import statements being ordered alphabetically. Next to that it would be great to group the import ... statements and then do the from ... import ... statements.
import logging
import requests
import usabilla as ub
from mock import Mock
from unittest import TestCase, main as unittest_main
If a request results in a non-200 status code, raise the exception instead of returning a `requests.Response`. Fixes usabilla#11
|
@tzengerink thanks for the speedy review + merge! |
If a request results in a non-200 status code, raise the exception
instead of returning a
requests.Response.Fixes #11