Skip to content

Conversation

@meta1-heart
Copy link

@meta1-heart meta1-heart commented Oct 24, 2017

@honest-hrundel honest-hrundel changed the title Сделал задание Бородин Николай Oct 24, 2017
@honest-hrundel
Copy link

🍅 Не пройден линтинг или базовые тесты

@honest-hrundel
Copy link

🍅 Не пройден линтинг или базовые тесты

@honest-hrundel
Copy link

🍏 Пройден линтинг и базовые тесты

@VasiliiKuznecov
Copy link

Привет, я сейчас переназначу тебе ментора, это нормально

@VasiliiKuznecov
Copy link

🔔

Copy link
Contributor

@mokhov mokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍅

@font-face
{
font-family: 'Bikham Cyr Script';
src: url(bikham-cyr-script_[allfont.ru].ttf) format(ttf);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ttf шрифты не везде работают

{
position: relative;
max-width: 1200px;
margin: 0 auto 4rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему решил использовать rem?

.remark_item
{
display: block;
width: .3em;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А здесь вдруг em?

margin-right: 1rem;
padding-bottom: .3rem;
font: .8rem 'Cutive Mono', monospace;
font-weight: bold;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bold тоже можно включить в правило выше


.paper_name
{
font: 70px 'Bikham Cyr Script';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А здесь вдруг px вообще

font: italic 1.25rem 'Cutive Mono';
margin: 1.5rem;
padding: .5rem;
border-top: 4px double #fadabb;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь можно сократить


.paper_date
{
font: italic 1.25rem 'Cutive Mono';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему нет деградации?

.entire_text
{
column-count: 3;
-moz-column-count: 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем нужны эти правила?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants