Fixed the path portion of URLs that included a database identifier#4
Open
klpauba wants to merge 1 commit intoupverter:masterfrom
Open
Fixed the path portion of URLs that included a database identifier#4klpauba wants to merge 1 commit intoupverter:masterfrom
klpauba wants to merge 1 commit intoupverter:masterfrom
Conversation
Author
|
It looks as if I might have duplicated at least some of the effort in pull request #2. |
|
Thanks for providing this fix, I've been banging my head against the wall and wondering what's going on. It would be great if this could be merged into the master and published so that the working version installs via pip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to http://fallabs.com/kyototycoon/spex.html:
I have found that, instead, the keys are written to the "default" database and of the form "/words.kch/I%20love%20you" since the path portion of the URL is encoded as "%2Fwords.kch%2FI%20love%20you". In other words, the library does not allow a developer to write key/value pairs to a server that provides access to multiple databases.
The changes provided reformats the path portion of the URL to conform to the specifications described above.