Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content for "using gel electrodes" guide and Pro kit #46

Merged
merged 11 commits into from
Jun 28, 2024

Conversation

bhawnasehgal
Copy link
Member

@lorforlinux please review the changes here and merge.

Copy link
Member

@lorforlinux lorforlinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhawnasehgal I have added some comments, please check and resolve.

guides/index.rst Outdated Show resolved Hide resolved
guides/index.rst Outdated Show resolved Hide resolved
guides/index.rst Outdated

.. only:: latex

1. `Skin preparation guide <https://docs.upsidedownlabs.tech/guides/usage-guides/skin-preparation/index.html>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For latex it's a bit hard, if the page is included in the PDF we prefer ref links otherwise proper links. Are we planning to create a PDF? Should we add these pages to that PDF so ref links can be added?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can skip creating PDFs for brief pages like these. Removing the latex code from guides, hardware, and DIY kits pages.

guides/usage-guides/using-gel-electrodes/index.rst Outdated Show resolved Hide resolved
guides/usage-guides/using-gel-electrodes/index.rst Outdated Show resolved Hide resolved

For more information, please check out detailed step by step `skin preparation guide <https://docs.upsidedownlabs.tech/guides/usage-guides/skin-preparation/index.html>`_.

.. note:: Always ensure that the prepared skin area is dry prior to applying the gel electrodes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alcohol swabs can make skin more dry if someone has a dry skin, can we mention this somewhere and probably test before adding this to the documentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched on the internet for the effect of alcohol swabs on the skin. Turns out it does leaves the skin dry, so adding the above note in the skin preparation guide

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll definitely test it out while performing experiments

guides/usage-guides/using-gel-electrodes/index.rst Outdated Show resolved Hide resolved
guides/usage-guides/using-gel-electrodes/index.rst Outdated Show resolved Hide resolved
hardware/index.rst Outdated Show resolved Hide resolved
kits/index.rst Outdated Show resolved Hide resolved
@bhawnasehgal bhawnasehgal merged commit fd94832 into upsidedownlabs:main Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants