Skip to content

add a body_opts argument to Network#disconnect #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add a body_opts argument to Network#disconnect #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/docker/network.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ def connect(container, opts = {}, body_opts = {})
reload
end

def disconnect(container, opts = {})
body = MultiJson.dump(container: container)
def disconnect(container, opts = {}, body_opts = {})
body = MultiJson.dump({ container: container }.merge(body_opts))
Docker::Util.parse_json(
connection.post(path_for('disconnect'), opts, body: body)
)
Expand Down
7 changes: 6 additions & 1 deletion spec/docker/network_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,15 @@
subject.remove
end

it 'connects a container to a network' do
it 'disconnects a container from a network' do
subject.disconnect(container.id)
expect(subject.info['Containers']).not_to include(container.id)
end

it 'force disconnects a container from a network' do
subject.disconnect(container.id, {}, force: true)
expect(subject.info['Containers']).not_to include(container.id)
end
end

describe '#remove' do
Expand Down