Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch cli based architecture #3

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

turkenf
Copy link
Contributor

@turkenf turkenf commented Oct 17, 2024

Description of your changes

In this PR:

  • Switched cli-based architecture
  • Changed group names
  • Fixed example manifests and added comments

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually tested with make run and index.docker.io/turkenf/provider-azapi:v0.0.0-6.g72fe70e

NAME                                              SYNCED   READY   EXTERNAL-NAME
                                      AGE
resourceaction.resources.azapi.upbound.io/start   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/rg-for-azapi/providers/Microsoft.App
Platform/Spring/example-spring/stop   10m

NAME                                          SYNCED   READY   EXTERNAL-NAME
                                            AGE
resource.resources.azapi.upbound.io/example   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/rg-for-azapi/providers/Microsoft.Contain
erRegistry/registries/registrytestupbound   31m

NAME                                                SYNCED   READY   EXTERNAL-NAME
                                  AGE
updateresource.resources.azapi.upbound.io/example   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/rg-for-azapi/providers/Microsoft.N
etwork/loadBalancers/example-lb   21m

Signed-off-by: Fatih Türken <[email protected]>
@turkenf turkenf marked this pull request as ready for review October 17, 2024 13:51
@turkenf turkenf requested a review from jeanduplessis October 17, 2024 13:51
@turkenf turkenf merged commit 74fbed2 into upbound:main Oct 17, 2024
7 checks passed
@turkenf turkenf deleted the switch-cli-based branch October 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants