Skip to content

Introduction of upstash q stash dashboard depreciation of upstash kafka product - #1

Open
up-ilter wants to merge 22 commits into
masterfrom
Introduction-of-Upstash-QStash-Dashboard-depreciation-of-Upstash-Kafka-Product
Open

Introduction of upstash q stash dashboard depreciation of upstash kafka product#1
up-ilter wants to merge 22 commits into
masterfrom
Introduction-of-Upstash-QStash-Dashboard-depreciation-of-Upstash-Kafka-Product

Conversation

@up-ilter

Copy link
Copy Markdown
Owner

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

up-ilter and others added 22 commits January 16, 2026 12:56
Co-authored-by: Dominic Medina <115744456+dd-dominic@users.noreply.github.com>
Co-authored-by: Dominic Medina <115744456+dd-dominic@users.noreply.github.com>
Co-authored-by: Dominic Medina <115744456+dd-dominic@users.noreply.github.com>
)

Adding the owner field to the grafana integration owned by the agent-integrations team.

The grafana integration is a community integration maintained by an external contributor.
According to the integrations-extras CODEOWNERS file, the default owner for such integrations
is the agent-integrations team.

The owner field has been added right below the app_id field in manifest.json.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
* Update Contrast Security ADR integration

* Revert unchanged diffs

* Apply suggestions from code review

---------

Co-authored-by: dd-pub-platform[bot] <157534740+dd-pub-platform[bot]@users.noreply.github.com>
Co-authored-by: bgoldberg122 <ben.goldberg@datadoghq.com>
Co-authored-by: Dominic Medina <115744456+dd-dominic@users.noreply.github.com>
Co-authored-by: Dominic Medina <115744456+dd-dominic@users.noreply.github.com>
We’re enabling new linter rules and some integrations are expected to remain non‑compliant.
Add permanent bypass annotations so CI stays green and not fail for new PRs.
* fix grpc check

* update docs and base check

* Fix integration test and timeout test

* regenerate

* Apply suggestion from @steveny91

Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com>

---------

Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com>

@up-ilter up-ilter left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gavel Review

Summary

This PR introduces a new feature to the gRPC check (v1.1.0), refactors the Upstash integration to focus on QStash metrics instead of Kafka (v1.2.0), and updates various manifest files and test configurations for multiple Datadog integrations. The changes improve SSL/TLS support for gRPC and reorganize documentation and assets for better focus on specific services.

Key changes:

  • Added secure_channel option to gRPC check enabling forced creation of secure channel with SSL configuration and target name override
  • Updated Upstash integration to remove Kafka metrics while enabling QStash metrics with new dashboard and visualization
  • Reorganized Upstash manifest and updated dashboards from Kafka-focused to QStash-focused
  • Added security event JSON samples to Contrast Security ADR integration
  • Updated metadata.csv for Upstash with sample_tags for better metric organization
  • Refreshed test YAML files across multiple integrations (Akamai, Aqua, Celerdata, Dagster, etc.)
  • Updated manifest.json files for Contrast Security ADR, Contrast Security, and Grafana integrations

Verdict

Metric Value
Risk Score 12/100
Recommendation request changes
Findings 5 accepted

Found 5 issue(s) across all reviewers. 1 blocking issue(s) require attention before merge. Overall risk score: 12/100. Changes are requested before merging.

Blockers

  • 🟠 HIGH secure_channel default value mismatch between config model and runtime code (grpc_check/datadog_checks/grpc_check/check.py:82)

Suggested Commits

  • fix: secure_channel default value mismatch between config model and runtime code

1 inline comment(s) could not be posted (line not in diff).


Generated by Gavel

@up-ilter up-ilter left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Lens Review

Summary

This PR adds new integration features and test fixtures across multiple integrations. It introduces gRPC check v1.1.0 with a new secure channel option, updates Upstash to v1.2.0 with QStash metrics and dashboards, and enhances Contrast Security ADR with test event fixtures. Multiple other integrations receive test log updates.

Key changes:

  • Enhanced grpc_check from v1.0.2 to v1.1.0 with new 'secure_channel' configuration option for secure connections without certificates
  • Updated Upstash integration to v1.2.0, adding QStash metrics and overview dashboards while deprecating Kafka metrics
  • Added comprehensive security test fixtures for Contrast Security ADR including DLP events, WAF alerts, and attack events
  • Added TLS certificate fixtures and expanded test coverage for gRPC check with new test cases
  • Updated Upstash documentation and metadata to reflect QStash-focused changes
  • Updated manifests and test logs across multiple integrations (Datadog contrastsecurity, Grafana, and various log collectors)

Verdict

Metric Value
Risk Score 16/100
Recommendation request changes
Findings 6 accepted

Found 6 issue(s) across all reviewers. 1 blocking issue(s) require attention before merge. Overall risk score: 16/100. Changes are requested before merging.

Blockers

  • 🟠 HIGH Tag list grows unboundedly on every check() invocation (grpc_check/datadog_checks/grpc_check/check.py:183)

Suggested Commits

  • fix: tag list grows unboundedly on every check() invocation

5 inline comment(s) could not be posted (line not in diff).


Generated by PR Lens

@up-ilter up-ilter left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpik Review

Summary

This PR enhances the gRPC check integration with secure channel support, refactors the Upstash integration with updated documentation and dashboard focused on QStash/Workflow metrics instead of Kafka, and updates security event schemas across multiple integrations with additional fields.

Key changes:

  • Added secure_channel configuration option to gRPC check for SSL/TLS connections with hostname override support
  • Bumped gRPC check version from 1.0.2 to 1.1.0 to reflect new secure channel feature
  • Replaced Upstash Kafka overview dashboard with QStash overview dashboard reflecting platform expansion beyond Kafka
  • Completely rewrote Upstash README to describe platform as unified Redis, Vector, QStash, and Workflow solution
  • Enhanced Contrast Security ADR security event JSON schemas with additional fields across DLP, WAF, exploit, and incident events
  • Updated test metadata YAML files for multiple integrations (akamai, aqua, celerdata, dagster, invary, jfrog_platform)

Verdict

Metric Value
Risk Score 0/100
Recommendation approve
Findings 1 accepted

Found 1 issue(s) across all reviewers. Overall risk score: 0/100. This PR looks good to merge.


Generated by Nitpik

@up-ilter up-ilter left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpik Review

Summary

This PR updates multiple integration checks and manifests, including adding a new secure channel option to the gRPC check, updating the Upstash integration to focus on QStash metrics, and refactoring manifest files across several integrations. The changes improve security configuration options and clean up deprecated features.

Key changes:

  • Added secure_channel configuration option to gRPC check (v1.1.0) to enable secure connections without explicit certificates
  • Updated Upstash integration (v1.2.0) to remove Kafka metrics and enable QStash metrics, including removal of associated dashboard files
  • Reorganized contrast_security_adr manifest to move owner field and remove queried data type classifier
  • Added owner field to multiple manifest.json files (contrastsecurity, grafana) for better ownership tracking
  • Updated test YAML logs across multiple integrations (akamai_datastream_2, aqua, celerdata, dagster, contrast_security_adr)
  • Fixed JSON formatting and added newlines to various manifest and configuration files for consistency
  • Updated build artifacts in in-toto link file to reflect all changes

Verdict

Metric Value
Risk Score 1/100
Recommendation approve
Findings 1 accepted

Found 1 issue(s) across all reviewers. Overall risk score: 1/100. This PR looks good to merge.


Generated by Nitpik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants