Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add failed pug tests #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: add failed pug tests #124

wants to merge 2 commits into from

Conversation

antfu
Copy link
Member

@antfu antfu commented Mar 16, 2022 •
edited
Loading

Downstream issue: nuxt/bridge#11

@antfu antfu mentioned this pull request Mar 16, 2022
Closed
@Shinigami92
Copy link
Contributor

Isn't this theoretically invalid? I think there is a missing v-else.
Currently if the condition would result in false there is no root-element in the component.
Not sure if it is statically analysed that it is always true in given example case.

@antfu
Copy link
Member Author

antfu commented Mar 16, 2022

The problem is that the parser does not understand pug, thus failing to parse <. You are talking about another thing that isn't the scope we should handle.

This was referenced Mar 16, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antfu @Shinigami92