fix: find collection properly when icon component includes :
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
antfu
approved these changes
Nov 2, 2023
userquin
deleted the
userquin/fix-handle-collection-properly-with-colon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #316 we included icon with colon (
:) handling, but finding the collection logic is wrong, we only need to find the collection by name: the logic in #316 was copy/paste from original handling, where we check first if the icon starts with the prefix + the icon: in the linked issue the problem was that we find the wrong collection.Linked Issues
check #317 (comment) (don't close it, it is another problem with string conversion)
Additional context