avoid normalize url #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Jan 19, 2025
src/_utils.ts
Outdated
| @@ -1,3 +1,5 @@ | |||
| import { ProxyServerOptions } from "./types"; | |||
There was a problem hiding this comment.
Suggested change
| import { ProxyServerOptions } from "./types"; | |
| import type { ProxyServerOptions } from "./types"; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 43.63% 43.63%
=======================================
Files 8 8
Lines 644 644
Branches 75 76 +1
=======================================
Hits 281 281
Misses 361 361
Partials 2 2 ☔ View full report in Codecov by Sentry. |
pi0
reviewed
Jan 19, 2025
src/_utils.ts
Outdated
| @@ -176,7 +178,7 @@ export function hasEncryptedConnection(req) { | |||
| * @api private | |||
| */ | |||
|
|
|||
| export function urlJoin(...args: string[]) { | |||
| export function urlJoin(options: ProxyServerOptions, ...args: string[]) { | |||
There was a problem hiding this comment.
I think we can alternatively use join from ufo. It handles join which much better care.
pi0
reviewed
Jan 19, 2025
src/server.ts
Outdated
| @@ -39,6 +39,7 @@ export class ProxyServer extends EventEmitter { | |||
|
|
|||
| this.options = options || {}; | |||
| this.options.prependPath = options.prependPath !== false; | |||
| this.options.normalizeUrl = options.normalizeUrl !== false; | |||
There was a problem hiding this comment.
We probably don't need an option if behavior is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #64 (comment)
I've added backport compatibility layer, so after this PR will be merged, we have to create another one for Nitro to avoid normalizing thouse slashes on nitro dev server.
https://github.com/nitrojs/nitro/blob/749f035dd00564fba7648712e5c9bd185591dc82/src/core/dev-server/server.ts#L334