Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculate box width without escape sequence chars #336

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

yongqi14
Copy link
Contributor

@yongqi14 yongqi14 commented Jan 8, 2025

resolves #316

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 29.31%. Comparing base (24c98ce) to head (2711393).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
examples/box.ts 0.00% 4 Missing ⚠️
src/utils/box.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #336       +/-   ##
===========================================
- Coverage   61.08%   29.31%   -31.77%     
===========================================
  Files          13       42       +29     
  Lines        1380     1644      +264     
  Branches       58       87       +29     
===========================================
- Hits          843      482      -361     
- Misses        537     1135      +598     
- Partials        0       27       +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx!

@pi0 pi0 merged commit c5c1534 into unjs:main Jan 13, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using consola.box with colors in the body adds extra padding
3 participants