Implement minimal built-in checks for Ibis backend #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ibis-dev #1885 +/- ##
============================================
+ Coverage 92.76% 92.91% +0.14%
============================================
Files 133 134 +1
Lines 9705 9722 +17
============================================
+ Hits 9003 9033 +30
+ Misses 702 689 -13 ☔ View full report in Codecov by Sentry. |
deepyaman
force-pushed
the
feat/ibis/builtin-checks
branch
2 times, most recently
from
3d0efc6 to
da8490f
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
deepyaman
force-pushed
the
feat/ibis/builtin-checks
branch
from
da8490f to
5744a4c
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
deepyaman
force-pushed
the
feat/ibis/builtin-checks
branch
from
3f3f649 to
b97d493
Compare
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
deepyaman
force-pushed
the
feat/ibis/builtin-checks
branch
from
4698e40 to
34daca5
Compare
cosmicBboy
reviewed
Jan 9, 2025
There was a problem hiding this comment.
thanks @deepyaman, this looks great!
Do you plan on implementing the other built-in checks in a separate PR? If so we can go ahead and merge this
Yep, will do in a separate PR! |
deepyaman
added a commit
to deepyaman/pandera
that referenced
this pull request
Feb 8, 2025
* Implement minimal built-in checks for Ibis backend Signed-off-by: Deepyaman Datta <[email protected]> * Implement `Column` validation for the Ibis backend Signed-off-by: Deepyaman Datta <[email protected]> * Promote check object to table during preprocessing Signed-off-by: Deepyaman Datta <[email protected]> * Remove extraneous fixture for backend registration Signed-off-by: Deepyaman Datta <[email protected]> * Resolve lint (unused imports, undefined variables) Signed-off-by: Deepyaman Datta <[email protected]> * Partially standardize docstrings of builtin checks Signed-off-by: Deepyaman Datta <[email protected]> * Fix the `preprocess` docstrings copied from pandas Signed-off-by: Deepyaman Datta <[email protected]> * Format pandera/backends/ibis/checks.py using Black Signed-off-by: Deepyaman Datta <[email protected]> --------- Signed-off-by: Deepyaman Datta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the built-in check machinery and a single validation (
equal_to). In future PRs, I (or somebody else) can: