Correctly handle "true" subtags in enum_keywords
macro
#6698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
unicode::Value
and theenum_keyword
macro to correctly handletrue
subtags. The added test has an extensive example of the (now fixed) incorrect behaviour.I think it's important to note that this also slightly changes the semantics of
Value
itself; previously, something likewould output the value
subtag
, while this PR makes it so that the sentinel subtagtrue
is always considered when pushing a subtag, making the above output the valuetrue-subtag
. We could also specialize onlyenum_keyword
to handle this correctly, but it seemed weird to haveenum_keyword
andValue
differ in behaviour.