Skip to content

ICU-22993 Add Modern Calendar API #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ICU-22993 Add Modern Calendar API #3452

wants to merge 2 commits into from

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Mar 25, 2025 •
edited
Loading

Add builder class FieldAccessorBuilder and immutable interfaces CalendarFieldAccessor, CenturyContext, WeekRules, and DateFieldRange,

Checklist

  • Required: Issue filed: ICU-22993
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang FrankYFTang added the incomplete Needs work; do not approve/merge as is. label Mar 25, 2025
sffc
sffc reviewed Mar 26, 2025
View reviewed changes
icu4c/source/i18n/unicode/calendar.h
*
* @return The minimal days required in the first week of the year.
*/
virtual uint8_t getMinimalDaysInFirstWeek() const = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLDR is deprecating this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
incomplete Needs work; do not approve/merge as is.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYFTang @sffc