Add v1 dashboard create endpoint via shared creation flow#653
Open
AnthonyMockler wants to merge 2 commits into
Open
Add v1 dashboard create endpoint via shared creation flow#653AnthonyMockler wants to merge 2 commits into
AnthonyMockler wants to merge 2 commits into
Conversation
7 tasks
12ce608 to
6f91742
Compare
6f91742 to
83ae6b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
Yes. API v1 could list and retrieve dashboards, but could not create them, which blocked API-first workflows and forced UI-only creation.
Describe the solution you'd like
This PR adds
POST /api/v1/dashboards/in API v1 by reusing the existing dashboard creation flow rather than introducing a second create path.Implemented behavior:
django_project/geosight/data/api/v1/dashboard.py).django_project/geosight/data/services/dashboard_create.py, wired fromdjango_project/frontend/views/admin/dashboard/create.py).Describe alternatives you've considered
Additional context
Design/implementation alignment used from our plan:
Scope delivered in this PR:
Out of scope (unchanged):
Implemented acceptance checklist:
POST /api/v1/dashboards/is available in API v1.Verification executed for this PR:
docker exec geosight_branch_dev python manage.py test geosight.data.tests.api.v1.dashboard.DashboardPermissionTest --keepdb --noinput→OK (14 tests).cd playwright/ci-test && npx playwright test tests/creator/project_creation/api_v1_create.ts tests/contributor/project_creation/api_v1_create_denied.ts --project=creator-chromium --project=contributor-chromium→PASS (7) FAIL (0).Closes #652