Skip to content

fix: Fix ManagedBrowser constructor and Windows encoding issues #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix ManagedBrowser constructor and Windows encoding issues #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crawl4ai/async_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,12 @@ class AsyncLogger(AsyncLoggerBase):
"COMPLETE": "●",
"ERROR": "×",
"DEBUG": "⋯",
"INFO": "ℹ",
"INFO": "i",
"WARNING": "⚠",
"SUCCESS": "✔",
"CRITICAL": "‼",
"ALERT": "⚡",
"NOTICE": "ℹ",
"NOTICE": "i",
"EXCEPTION": "❗",
"FATAL": "☠",
"DEFAULT": "•",
Expand Down
22 changes: 16 additions & 6 deletions crawl4ai/browser_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,15 +615,20 @@ async def launch_standalone_browser(self,
self.logger.info(f"Debugging port: {debugging_port}", tag="CDP")
self.logger.info(f"Headless mode: {headless}", tag="CDP")

# Create managed browser instance
managed_browser = ManagedBrowser(
# Create browser config
browser_config = BrowserConfig(
browser_type=browser_type,
user_data_dir=profile_path,
headless=headless,
logger=self.logger,
debugging_port=debugging_port
)

# Create managed browser instance
managed_browser = ManagedBrowser(
browser_config=browser_config,
logger=self.logger
)

# Set up signal handlers to ensure cleanup on interrupt
original_sigint = signal.getsignal(signal.SIGINT)
original_sigterm = signal.getsignal(signal.SIGTERM)
Expand Down Expand Up @@ -809,15 +814,20 @@ async def launch_builtin_browser(self,
user_data_dir = os.path.join(self.builtin_browser_dir, "user_data")
os.makedirs(user_data_dir, exist_ok=True)

# Create managed browser instance
managed_browser = ManagedBrowser(
# Create browser config
browser_config = BrowserConfig(
browser_type=browser_type,
user_data_dir=user_data_dir,
headless=headless,
logger=self.logger,
debugging_port=debugging_port
)

# Create managed browser instance
managed_browser = ManagedBrowser(
browser_config=browser_config,
logger=self.logger
)

try:
# Start the browser
await managed_browser.start()
Expand Down
2 changes: 1 addition & 1 deletion crawl4ai/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ def create_box_message(
# Define border and text colors for different types
styles = {
"warning": ("yellow", "bright_yellow", "⚠"),
"info": ("blue", "bright_blue", "ℹ"),
"info": ("blue", "bright_blue", "i"),
"debug": ("lightblack", "bright_black", "⋯"),
"success": ("green", "bright_green", "✓"),
"error": ("red", "bright_red", "×"),
Expand Down