Skip to content

test(app): run launcher matrix tests in parallel #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umputun merged 1 commit into from
Sep 9, 2026
Merged

test(app): run launcher matrix tests in parallel #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/plugin_exit_code_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ func assistantTranscriptLine(t *testing.T, phase, text string) string {
}

func TestShellLaunchersPreserveAnnotationExitCode(t *testing.T) {
t.Parallel()
if runtime.GOOS == "windows" {
t.Skip("shell launchers are not used on windows")
}
Expand Down Expand Up @@ -151,6 +152,7 @@ func TestShellLaunchersPreserveAnnotationExitCode(t *testing.T) {
for _, launcher := range launchers {
for _, backend := range launcherBackends() {
t.Run(launcher.name+"/"+backend.name, func(t *testing.T) {
t.Parallel()
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
run := launcherRun{backend: backend, code: tc.code, output: tc.output}
Expand Down Expand Up @@ -422,6 +424,7 @@ func TestAgtermPaneOverlayOptIn(t *testing.T) {
// that reach the trap's close; the tab fallthrough closes nothing, and every case from the
// dispatch onward is the preserve half.
func TestHerdrSignalPaneOwnership(t *testing.T) {
t.Parallel()
if runtime.GOOS == "windows" {
t.Skip("shell launchers are not used on windows")
}
Expand Down Expand Up @@ -518,6 +521,7 @@ func TestHerdrSignalPaneOwnership(t *testing.T) {
for lname, lpath := range launchers {
for _, tc := range tests {
t.Run(lname+"/"+tc.name, func(t *testing.T) {
t.Parallel()
backend := launcherBackend{name: "herdr", command: "herdr", env: map[string]string{"HERDR_ENV": "1"}}
env := fakeLauncherEnv(t, launcherRun{backend: backend, code: exitCodeAnnotations, output: "x\n"})
argsFile := filepath.Join(env["TMPDIR"], "herdr-args")
Expand Down Expand Up @@ -603,6 +607,7 @@ func countHerdrCalls(calls []string, prefix string) int {
// with the synchronous fake the sentinel exists before the wait loop starts, so the
// liveness probe is only observable in the deferred-sentinel cases.
func TestHerdrPaneOverlayOptIn(t *testing.T) {
t.Parallel()
if runtime.GOOS == "windows" {
t.Skip("shell launchers are not used on windows")
}
Expand Down Expand Up @@ -791,6 +796,7 @@ func TestHerdrPaneOverlayOptIn(t *testing.T) {
for _, launcher := range launchers {
for _, tc := range cases {
t.Run(launcher.name+"/"+tc.name, func(t *testing.T) {
t.Parallel()
backend := launcherBackend{name: "herdr", command: "herdr", env: map[string]string{
"HERDR_ENV": "1",
}}
Expand Down