Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Construct Refactor && jsii build #26

Merged
merged 4 commits into from
Mar 4, 2025
Merged

Construct Refactor && jsii build #26

merged 4 commits into from
Mar 4, 2025

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Mar 3, 2025 •
edited
Loading

  • Refactor construct to (I think this construct grouping makes sense):

    • Onconalyser
    • NextflowConfig
    • NextflowPipelineEnvironment
    • NextflowTaskEnvironment
    • OncoanalyserJobDefinition

  • Add jsii build to the root package.json

Resolve #7 #18

@williamputraintan williamputraintan self-assigned this Mar 3, 2025
qclayssen
qclayssen approved these changes Mar 3, 2025
View reviewed changes
Copy link

@qclayssen qclayssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamputraintan williamputraintan linked an issue Mar 4, 2025 that may be closed by this pull request
Refactor into constructs #18
Closed
@williamputraintan williamputraintan merged commit 52e4dab into main Mar 4, 2025
2 checks passed
@williamputraintan williamputraintan deleted the feat/jsii-build branch March 4, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpatto andrewpatto andrewpatto approved these changes

@qclayssen qclayssen qclayssen approved these changes

@scwatts scwatts Awaiting requested review from scwatts

@mmalenic mmalenic Awaiting requested review from mmalenic

Assignees

@williamputraintan williamputraintan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor into constructs Publish as a re-usable NPM CDK package
3 participants
@williamputraintan @andrewpatto @qclayssen