-
Notifications
You must be signed in to change notification settings - Fork 804
Adding Lychee Config files #7363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So great to have a rule that checks for broken links!
I'm very excited to see how this will help us out 💪
I've made some suggestions to the YAML file.
See how a comment looks with the suggested changes here: sofietoft#91 (comment)
Co-authored-by: sofietoft <[email protected]>
Co-authored-by: sofietoft <[email protected]>
Co-authored-by: sofietoft <[email protected]>
Co-authored-by: sofietoft <[email protected]>
Co-authored-by: sofietoft <[email protected]>
Co-authored-by: sofietoft <[email protected]>
Thank you for testing it out and adding your suggestions, @sofietoft 🙌 The output message definitely looks fantastic, it's well-spaced and easy to read 💪 I've incorporated all your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Let's get this merged, so we can start informing contributors about potential broken links in their PRs 👏
📋 Description
Adding Lychee to check for broken links in incoming PRs.
To test:
choco install lychee
command on Windows PowerShell to install Lychee. You might want to check the command for the Linux machine.lychee --version
..github/lychee.toml
..lycheeignore
at the repo root.lychee --config .github/lychee.toml --format json --output lychee_output_cm.json "16/umbraco-cms/**/*.md"
..github/lychee.toml
.github/workflows/check-broken-pr-links.yml
[github-actions]
listing the broken links, and the workflow should fail.📎 Related Issues (if applicable)
✅ Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
Deadline (if relevant)
Anytime
📚 Helpful Resources