Skip to content

Add info about IPublishedContentQuery in background task #6997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Apr 2, 2025

Description

Based on issue: umbraco/Umbraco-CMS#18883

It would be useful to link to this from here regarding documentation about custom filter:
https://docs.umbraco.com/umbraco-cms/reference/content-delivery-api/extension-api-for-querying#custom-filter

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

@bjarnef bjarnef changed the title Add info about IPublishedContentQuery in background task Add info about IPublishedContentQuery in background task Apr 2, 2025
@bjarnef
Copy link
Contributor Author

bjarnef commented Apr 2, 2025

@kjac @AndyButland I added some documentation about this and not just on comment of method in source code :)

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjarnef for the PR 🙌 I have added a suggestion to keep the warning concise and moved the extra info as a paragraph above and below it.

Let me know if it doesn't make sense, or feel free to adjust.

@bjarnef
Copy link
Contributor Author

bjarnef commented Apr 3, 2025

@eshanrnh great! 🙌 it should probably also be added to v13 docs .. and a link from Delivery API filter from here https://docs.umbraco.com/umbraco-cms/reference/content-delivery-api/extension-api-for-querying#custom-filter would be great.

@kjac
Copy link
Contributor

kjac commented Apr 3, 2025

Hi all,

@bjarnef thanks for this 💪

I do feel this is very specific for IPublishedContentQuery. Wouldn't it be better to put this in the dedicated reference for that service (https://docs.umbraco.com/umbraco-cms/reference/querying/ipublishedcontentquery)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants