Do not set icon color if the item is selected

[lauraneto]

If there's an existing issue for this PR then this fixes #19400

This is an addition to PR #17703, so the same behavior happens for the selected state.
This can be tested using the document picker, multi url picker or by selecting "Allowed child node types" in document or media types.

[Copilot]

Pull Request Overview

Adds support for treating the selected state like the active state when determining icon coloration in tree items.

• Include _isSelected in the conditional that picks the “iconWithoutColor” variant for active and selected items.
• Expose _isSelected as a protected property so subclasses can reference it.
• Update both document and media tree item components, plus the base tree-item renderer.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/packages/media/media/tree/tree-item/media-tree-item.element.ts	Updated icon to use iconWithoutColor when the item is selected
src/packages/documents/documents/tree/tree-item/document-tree-item.element.ts	Updated icon to use iconWithoutColor when the item is selected
src/packages/core/tree/tree-item/tree-item-base/tree-item-element-base.ts	Changed _isSelected to protected and added selected-state check to default icon rendering

Comments suppressed due to low confidence (2)

src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-base/tree-item-element-base.ts:74

• [nitpick] Exposing _isSelected as a protected field breaks encapsulation. Consider keeping it private and providing a protected or public getter isSelected() for subclasses to use.

protected _isSelected = false;

src/Umbraco.Web.UI.Client/src/packages/media/media/tree/tree-item/media-tree-item.element.ts:15

• There’s new behavior for the selected state affecting icon rendering. Add unit tests to ensure iconWithoutColor is used when _isSelected is true.

<span id="icon-container" slot="icon">

[AndyButland]

Looks good to me and can see it fixes the issue.

I've just acted on Copilot's recommendation of a helper method, which seems like a good idea given we have this icon version switch in three places.

If you are happy with my update, please go ahead and merge.

I see there are a few small FE fixes going in still to release/16.0, so I think it would be OK cherry-pick it in there so it's part of RC4, and label the related issue it with this version. - following discussion, let's keep this for 16.1 and not add to 16.0, as it's not a regression in the RC itself.