V15: Add progress UI to the Upload Field property editor #18188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOvergaard
added
category/ux
…est to be aborted
|
@iOvergaard instead of having the "remove" action until file is uploaded, would it be better having a "cancel" action while upload is in progress? That way it would still show "card" even though the operation is cancelled. |
Added "Cancel" button, from @bjarnef's suggestion.
leekelleher
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Tested out, works great! 🚀
Following @bjarnef's suggestion I changed the button to "Cancel" during the upload progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds uploader UI for the Upload Field property editor UI used in the details view of the Media Library.
Changes
AbortSignal, which is facilitated through anAbortControllerallowing the request to be canceledFileReaderanymore, which avoids loading the file into memorySuccess
2025-01-31.at.11.26.26.-.Coral.Heron.mp4
Error
2025-01-31.at.11.27.31.-.Maroon.Jaguar.mp4
Canceled
2025-01-31.at.11.57.20.-.Scarlet.Python.mp4