V15/sort by selected icons #18158
Merged
V15/sort by selected icons #18158
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct to indicate that it is grabable, and applys the choosen color
bjarnef
reviewed
Jan 29, 2025
...c/packages/core/tree/entity-actions/sort-children-of/modal/sort-children-of-modal.element.ts
Outdated
Show resolved
Hide resolved
|
According to the related issue this has already been fixed in #17904 ? |
|
Hi bjarnef thanks for your input. |
|
I have realized that we do not know where to find the icon in this generic modal. I have reverted the icon in this PR to the one that we currently use. This PR then changes padding in the table so each item takes up less space. |
madsrasmussen
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes
Sort children displays default icon instead of selected icon #18153
Description
adds back the custom icon for the content nodes and give a hover effect to indicate that it is grabable, and applys the choosen color
Steps to reproduce