Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback as entity action + Picker data updates #18154

Merged
merged 34 commits into from
Jan 31, 2025
Merged

Rollback as entity action + Picker data updates #18154

merged 34 commits into from
Jan 31, 2025

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Jan 29, 2025 •
edited
Loading

This PR fixes a couple of issues with the Rollback action.

  • It was tightly coupled to the workspace context, preventing it from being used as an entity action.
  • It did not roll back a variant name (solved by Fixes rollback of variant page name #18136).
  • It did not update the affected document correctly when done.

The last issue was resolved in a way that could also fix other similar bugs:

@madsrasmussen
remove condition in manifest
724cda7
@madsrasmussen
wip decouple of workspace
a271822
@madsrasmussen
Merge branch 'v15/dev' into v15/feature/enable-document-rollback-as-e…
d636bba 
…ntity-action
@madsrasmussen
Merge branch 'v15/dev' into v15/feature/enable-document-rollback-as-e…
01eed53 
…ntity-action
@madsrasmussen
get name from language
6d31a0a
@madsrasmussen
update naming
4988162
@madsrasmussen
extract logic from rendering
43005c7
@madsrasmussen
support invariant documents
7e68573
@madsrasmussen
styling adjustments
d343ab3
@madsrasmussen
Update rollback-modal.element.ts
eda1396 
hide box if there are no cultures
@madsrasmussen
change weight
a68ff52
@madsrasmussen
reload workspace on entity detail updated event
1048234
@madsrasmussen
submit modal
77f6ac8
@madsrasmussen
render empty states
1180084
@madsrasmussen
disable submit button until a version is selected
bf5caf6
@madsrasmussen
remove from document workspace
80b8d6f
@madsrasmussen
add event discriminator option
0a78648
@madsrasmussen
dispatch event when content is saved
7ac2fff
@madsrasmussen
listen to events on entity updates
fc55f5e
@madsrasmussen
remove detail from event
15342ea
@madsrasmussen
Update index.ts
ff71caf
@madsrasmussen
Update rollback-modal.element.ts
ee1dff2
@madsrasmussen
remove unused
4ff07d3
@madsrasmussen
reload items
e6cc9cf
@madsrasmussen
use reload
aa5c58f
@madsrasmussen
Merge branch 'v15/dev' into v15/feature/enable-document-rollback-as-e…
08a621b 
…ntity-action
@madsrasmussen
Merge branch 'v15/dev' into v15/feature/enable-document-rollback-as-e…
017777f 
…ntity-action
@madsrasmussen
correct name
0b5e760
@madsrasmussen
dispatch event from detail-workspace-base
6b94a20
@madsrasmussen madsrasmussen changed the title Rollback as entity action Rollback as entity action + Picker data updates Jan 29, 2025
@madsrasmussen madsrasmussen marked this pull request as draft January 29, 2025 09:10
@madsrasmussen madsrasmussen marked this pull request as ready for review January 29, 2025 10:21
@nielslyngsoe nielslyngsoe merged commit 7c5c3fd into v15/dev Jan 31, 2025
28 of 29 checks passed
@nielslyngsoe nielslyngsoe deleted the v15/feature/enable-document-rollback-as-entity-action branch January 31, 2025 11:59
This was referenced Feb 1, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
area/frontend category/ui User interface release/15.3.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsrasmussen @nielslyngsoe @AndyButland