Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Data type create options #18023

Merged
merged 10 commits into from
Jan 20, 2025

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Jan 17, 2025

This PR registers the Data Type creation options as extensions. This way, we can use the generic create option modal and deprecate the custom implementation. It also gives us the ability to easily add create options to the folder collection.

Create Modal
Screenshot 2025-01-17 at 21 38 15

Folder Create options
Screenshot 2025-01-17 at 21 38 23

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, all working as expected! 😀

Just noticed the UmbDeprecation helper, (must have been added during my vacation). 😎

A general thought about the Collection Create Actions... they open a popover will the options, but no descriptions. I wondering if the Create button itself should follow the same interaction as from the menu, e.g. open the side modal? for a consistent experience.🤔

@leekelleher leekelleher merged commit a6b9f20 into v15/dev Jan 20, 2025
30 checks passed
@leekelleher leekelleher deleted the v15/feature/data-type-create-options branch January 20, 2025 08:27
@madsrasmussen
Copy link
Contributor Author

if the Create button itself should follow the same interaction as from the menu, e.g. open the side modal?

I had a brief chat with @nielslyngsoe about this some time ago, and I think we came to a solution where we want to make the create button dropdown bigger so we can also include the descriptions in that one.

I also personally like that the create options are right next to the button.

Just noticed the UmbDeprecation helper, (must have been added during my vacation).

Yeah, that sounds about right 😄 This way our deprecation warnings aren't only visible in the TS/JS docs. Hopefully, this will make it clear if some deprecated code is being executed. Let me know what you think about this approach.

@nielslyngsoe
Copy link
Member

nielslyngsoe commented Jan 20, 2025

@leekelleher @madsrasmussen

Yes, that is right. Its the classic design decision, consistency or not. And in this case I think the perfect middle ground would be to grab the content of the modal, and show it in this create-popout. So you see the same, and still do not need to move your mouse far.

So ideally the dropdown/popout has this content:
image

But looking at this there is another thing to correct — the description for the folder is way to over explaining what the folder does, People should know what the qualities of a folder is, so lets not visually overwhelm so much. It could be "Organize the Data-Types in folders"

and then to give equal visual weight the Data-Type should get a description as well. "A reusable property configuration"

I also did not know about UmbDeprecation, very nice to have... :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants