-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Data type create options #18023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out, all working as expected! 😀
Just noticed the UmbDeprecation
helper, (must have been added during my vacation). 😎
A general thought about the Collection Create Actions... they open a popover will the options, but no descriptions. I wondering if the Create button itself should follow the same interaction as from the menu, e.g. open the side modal? for a consistent experience.🤔
I had a brief chat with @nielslyngsoe about this some time ago, and I think we came to a solution where we want to make the create button dropdown bigger so we can also include the descriptions in that one. I also personally like that the create options are right next to the button.
Yeah, that sounds about right 😄 This way our deprecation warnings aren't only visible in the TS/JS docs. Hopefully, this will make it clear if some deprecated code is being executed. Let me know what you think about this approach. |
This PR registers the Data Type creation options as extensions. This way, we can use the generic create option modal and deprecate the custom implementation. It also gives us the ability to easily add create options to the folder collection.
Create Modal
Folder Create options