Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Added a maxlength setting to the regular expression pattern field (15) #17984

Draft
wants to merge 1 commit into
base: v15/dev
Choose a base branch
from

Conversation

AndyButland
Copy link
Contributor

@AndyButland AndyButland commented Jan 14, 2025

WIP... this is looking to implement the same fix as for #17982

See further (HQ internal) discussion here: https://umbraco.slack.com/archives/C027U315T54/p1736868267763389

Current issues:

  • I'm seeing a validation message appear, but not the one I'd ideally like to show which is set on maxlengthMessage
    • But that's not so important - the default message is OK if that's what we can use currently.
  • I can still submit the modal, but really I shouldn't be able to until the validation issues are fixed.
    • Actually, I see the same with the existing validation for the "Name" field - that also shows a message, but I can submit the modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant