Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issues related to the setting of a schedule for content publishing #17868

Merged
merged 36 commits into from
Feb 13, 2025
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
0ea9be4
Render scheduled publish and unpublish on content info workspace view.
AndyButland Dec 26, 2024
74a8444
Populate previously saved schedule on set schedule dialog.
AndyButland Dec 27, 2024
ad9aabf
Hide workspace button actions that require a saved document when the …
AndyButland Dec 27, 2024
7743417
Convert between local and server time when saving and displaying sche…
AndyButland Dec 29, 2024
2cf322f
Fix issues with clearing of previously set schedule.
AndyButland Dec 29, 2024
920ea83
Updated OpenApi.json to align with APi amends.
AndyButland Dec 30, 2024
cc9478c
Added missing constant.
AndyButland Jan 1, 2025
826b5d5
Merge branch 'v15/dev' into v15/bugfix/scheduled-publish
AndyButland Jan 8, 2025
c97ae0f
Fixes following merge.
AndyButland Jan 8, 2025
d57f4e0
Fixed schedule mapping for invariant content.
AndyButland Jan 8, 2025
576b286
Fixed display of publishing/pending changes on info workspace view.
AndyButland Jan 8, 2025
0a63c9f
Removed debug code.
AndyButland Jan 8, 2025
b3bf26e
Merge branch 'v15/dev' into v15/bugfix/scheduled-publish
AndyButland Jan 8, 2025
99910fa
Merge branch 'v15/dev' into v15/bugfix/scheduled-publish
nielslyngsoe Jan 20, 2025
11069f1
Merge branch 'v15/dev' into v15/bugfix/scheduled-publish
iOvergaard Feb 12, 2025
8332765
fix: adds missing localization keys
iOvergaard Feb 12, 2025
580f40a
chore: eslint
iOvergaard Feb 12, 2025
626135e
fix: render only the selectAll checkbox when more than one language i…
iOvergaard Feb 12, 2025
3c87c44
feat: adds last edited date
iOvergaard Feb 12, 2025
cee0ce5
feat: adds 'last published' date
iOvergaard Feb 12, 2025
36eaacc
fix: format input datetimes to datetime-local
iOvergaard Feb 12, 2025
33e990c
fix: converts the datetime string to an ISO format before sending to …
iOvergaard Feb 12, 2025
9babc9f
chore: adds more types to ensure type safety
iOvergaard Feb 12, 2025
31723f9
chore: use initialized boolean
iOvergaard Feb 12, 2025
3a513b2
fix: makes schedule modal options-based to isolate the `selection` to…
iOvergaard Feb 12, 2025
470fca8
docs: fix comment
iOvergaard Feb 13, 2025
e982288
docs: adds comment
iOvergaard Feb 13, 2025
ab6236c
fix: use helper function to update selection
iOvergaard Feb 13, 2025
8b1fb26
revert commit to prevent breaking change
iOvergaard Feb 13, 2025
5016c5c
chore: eslint
iOvergaard Feb 13, 2025
a6ed715
Merge remote-tracking branch 'origin/v15/dev' into v15/bugfix/schedul…
iOvergaard Feb 13, 2025
027dfbc
Whitespace tidy-up
leekelleher Feb 13, 2025
b0482f6
fix: stores a copy of the prevalues to be able to update that interna…
iOvergaard Feb 13, 2025
4c6fed3
chore: removes unused function
iOvergaard Feb 13, 2025
fccaa42
fix: unifies any pickable filters into one function
iOvergaard Feb 13, 2025
dd022be
Merge branch 'v15/bugfix/scheduled-publish' of https://github.com/umb…
iOvergaard Feb 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed display of publishing/pending changes on info workspace view.
  • Loading branch information
AndyButland committed Jan 8, 2025

Verified

This commit was signed with the committer’s verified signature.
JonGilmore Jon Gilmore
commit 576b28649e59567023d4cd4f2e54ef739b6e6677
Original file line number Diff line number Diff line change
@@ -49,6 +49,9 @@ export class UmbDocumentPublishedPendingChangesManager extends UmbControllerBase
mergedDataClone.variants.forEach((variant) => this.#cleanVariantForComparison(variant));
publishedDataClone.variants.forEach((variant) => this.#cleanVariantForComparison(variant));

// remove template from the comparison (doesn't affect publishable changes, and the published version is coming through as null)
mergedDataClone.template = null;
publishedDataClone.template = null;
const hasChanges = jsonStringComparison(mergedDataClone, publishedDataClone) === false;

if (hasChanges) {