Skip to content

578 Version filter doesn't appear to be working when searching #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

578 Version filter doesn't appear to be working when searching #641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
815c5b6
Added additional versions (Uno + Heartcore)
Oct 16, 2020
30375a1
Added forum version field to search
Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion OurUmbraco/Our/Examine/OurSearcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private ISearchCriteria GetSearchCriteria(BaseLuceneSearcher searcher)
// * docs version (MajorDocsVersion) supplied, give current version and NEGATE OTHERS
// * no docs version (MajorDocsVersion) is not suplied, use it and NEGATE others
// * all versions are requests, this is currently not implemented
var currentMajorVersions = new string[] { "6", "7", "8" };
var currentMajorVersions = new string[] { "4", "6", "7", "8", Constants.Forum.UnoVersionNumber.ToString(), Constants.Forum.UnoVersionNumber.ToString() };

// add mandatory majorVersion is parameter is supplied
string versionToFilterBy = MajorDocsVersion == null
Expand All @@ -80,6 +80,7 @@ private ISearchCriteria GetSearchCriteria(BaseLuceneSearcher searcher)
foreach (var versionToNegate in versionsToNegate)
{
sb.AppendFormat("-majorVersion:{0} ", versionToNegate);
sb.AppendFormat("-version:{0} ", versionToNegate);
}
}

Expand Down