Conversation
…25 (#129) * change goosies 2023 -> 2024 and goosies 2024 -> 2025
* TECH-146 Add Lyle * uncomment file that wasn't working
#132) * fix a bug where upcoming event does not show when eventdate and today is the same * change event date back to normal
* added function but mobile still not optimized * Add images config to manage home Image component and optimization are handled * Fix eslint * Remove duplicate method comment * optimize image size --------- Co-authored-by: Andre Cruz <andresonic14@hotmail.com> Co-authored-by: Kanna Kim <kimkanna18@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This “May 2026 Release” PR bundles several small site updates: event listing/page updates (including new Goosies 2025 page), image optimization tweaks for Next.js images, and a few content/data fixes (team, researchers, logos, CI note).
Changes:
- Update event data and pages (Goosies 2024 page rewrite, add Goosies 2025, adjust upcoming-events filtering).
- Introduce reusable Next.js
<Image>compression helpers and tunenext.config.mjsimage sizing. - Miscellaneous fixes/updates: contact form reset after submit, lounge page ISR revalidate, sponsor logo SVG replacement, navbar route cleanup, PR template note update.
Reviewed changes
Copilot reviewed 16 out of 21 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/data/routes.ts | Removes “Elections 2026” from navbar route list. |
| src/data/researchers.ts | Updates a researcher display name. |
| src/data/prev-team.ts | Adds missing previous exec president entry. |
| src/data/events.ts | Updates Goosies entries and upcoming-events filtering logic. |
| src/components/profile-modal.tsx | Applies compressed image props to profile modal avatar. |
| src/components/profile-card.tsx | Applies compressed image props to profile card avatar. |
| src/components/page-header.tsx | Adds banner image compression/preload props for headers. |
| src/components/compress-image.tsx | New helper functions for consistent Next.js image sizing/quality. |
| src/app/lounge/page.tsx | Adds revalidate for ISR caching. |
| src/app/events/goosies-2025/page.tsx | Adds Goosies 2025 photo gallery page. |
| src/app/events/goosies-2024/page.tsx | Replaces photo gallery with a custom event info page. |
| src/app/events/goosies-2023/page.tsx | Removes old Goosies 2023 page. |
| src/app/elections/page.tsx | Removes the “Election Package” link. |
| src/app/contact/page.tsx | Resets the contact form after submission. |
| public/img/sponsors/UMDeptCS.svg | Replaces Dept. of CS sponsor logo SVG. |
| next.config.mjs | Configures image/device sizes and qualities for Next Image optimization. |
| .github/pull_request_template.md | Updates CI-skip guidance in PR template. |
Comments suppressed due to low confidence (2)
src/app/events/goosies-2024/page.tsx:80
next/imageexpects numericwidth/heightprops; this instance also passes them as strings. Use numeric literals to avoid TS/build errors.
<Image
height="1000"
width="1000"
src="/img/goosies/goosies2024.png"
alt="Goosies Poster for 2024"
className="object-cover"
/>
src/app/events/goosies-2024/page.tsx:121
- Same nested interactive-elements issue here (
LinkinsideButton). UseasChild(or a non-link button) to avoid<button><a/></button>markup.
<Button size="lg">
<Link href="#">Registration Closed</Link>
</Button>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+17
to
+23
| <Image | ||
| height="1000" | ||
| width="1000" | ||
| src="/img/goosies/goosies2024.png" | ||
| alt="Goosies Poster for 2024" | ||
| className="object-cover" | ||
| /> |
Comment on lines
+62
to
+66
| <Button size="lg"> | ||
| <Link href="#">Registration Closed</Link> | ||
| </Button> | ||
| <br /> | ||
| <Button size="lg"> |
Comment on lines
+85
to
92
| 'goosies-2024', | ||
| { | ||
| title: 'Goosies 2023', | ||
| title: 'Goosies 2024', | ||
| description: goosiesDescription, | ||
| href: 'events/goosies-2023', | ||
| href: 'events/goosies-2024', | ||
| internal: true, | ||
| linkText: 'View Photos →', | ||
| image: '/img/backgrounds/home.jpg', |
Comment on lines
7
to
15
| <div className="desktop-only"> | ||
| <div className="w-full h-[500px] overflow-hidden relative"> | ||
| <Image | ||
| className="relative object-cover" | ||
| fill | ||
| src={image} | ||
| alt={title} | ||
| {...getCompressedBannerImageProps(1920, 200)} | ||
| /> |
Comment on lines
+36
to
+37
| fetchPriority="high" | ||
| loading="eager" |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue References
Type of Change
Description
Descriptions for each of the changes can be found in their respective PRs and JIRA issues.
Additionally, 2 non JIRA tracked commits are to be merged:
Testing
Ensure you've tested the following, if applicable. Select all that apply.