Optimized MetricsBar & Fixed Mobile Layout #3258
Open
+172
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TanerKp is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR consolidates metrics bar functionality and improves mobile responsiveness across the website's analytics pages through a new WebsiteMetrics wrapper component.
- Added new
/src/app/(main)/websites/[websiteId]/WebsiteMetrics.tsxcomponent that handles shared metrics functionality like date filtering, comparison mode, and sticky positioning - Implemented responsive grid layout in
WebsiteMetrics.module.cssthat switches from 2:1 ratio on desktop to single column on mobile (<1200px) - Simplified
EventsMetricsBarandSessionsMetricsBarby removing redundant layout code and date filter functionality - Wrapped existing metrics bars with
WebsiteMetricscomponent across pages for consistent mobile-friendly layout - Removed unused props from
WebsiteMetricsBarcomponent that were moved toWebsiteMetrics
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
10 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋🏼
I refactored
{route}MetricsBarand created a newWebsiteMetricscomponent to remove redundant code and improve maintainability. Most importantly, I fixed the mobile UI layout.Before:
After:
