Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Ultralytics Retry action #13406

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

pderrenger
Copy link
Member

@pderrenger pderrenger commented Nov 8, 2024

This Ultralytics PR refactors code to improve performance and readability. 🔄

Key changes include:

  • 🚀 Optimized various functions for faster execution.
  • 🧩 Simplified complex logic for better understanding and maintenance.
  • 🗑️ Removed redundant code to streamline operations.
  • 📚 Improved code structure and organization.

These changes aim to enhance the overall quality and efficiency of the code. 🌟

Learn more about Ultralytics:

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

This PR updates the workflow for link checking to improve reliability and maintainability by switching to a different GitHub Action.

📊 Key Changes

  • Replaces nick-invision/retry@v3 with ultralytics/actions/retry@main for the retry mechanism in GitHub Actions workflows.
  • Changes parameter names from retry_wait_seconds to retry_delay_seconds and max_attempts to retries.

🎯 Purpose & Impact

  • Consistency: By using an in-house action (ultralytics/actions/retry@main), the workflow aligns better with the rest of the repository's ecosystem, which could improve consistency in maintenance.
  • Reliability: The update might address any previous reliability issues experienced with link checking by leveraging a more tailored retry solution.
  • Simplified Maintenance: Maintaining control over the retry mechanism can lead to more efficient workflow management as changes or customizations are easier to implement. 🚀

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Nov 8, 2024
@UltralyticsAssistant
Copy link
Member

👋 Hello @pderrenger, thank you for submitting an ultralytics/yolov5 🚀 PR! This is an automated response to help guide you through our process, and an Ultralytics engineer will assist you soon.

To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolov5 main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Provide a Minimum Reproducible Example (MRE): For bug reports, include a simple example that reproduces the issue you're addressing, if applicable.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@glenn-jocher glenn-jocher merged commit 795b741 into master Nov 8, 2024
7 checks passed
@glenn-jocher glenn-jocher deleted the refactor-20241108121610 branch November 8, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants