First PR of domain module compatibility #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… out of handling.
… use that to save the CSS. Deletion of obsolete files does not seem to be happening.
ctgraham
requested changes
Jul 25, 2025
Member
ctgraham
left a comment
ctgraham
left a comment
There was a problem hiding this comment.
Some early changes and questions.
ctgraham
reviewed
Jul 25, 2025
ctgraham
reviewed
Jul 25, 2025
…e with Drupal standards. A bug preventing deletion of old files is also resolved.
ctgraham
requested changes
Aug 11, 2025
| \Drupal::service('file_system')->chmod($file); | ||
| } | ||
| // delete obsolete file | ||
| if ($oldPath!=$file) { |
Member
There was a problem hiding this comment.
I think this will get flagged by the linter for no spaces between the two sides of the inequality check.
| '#default_value' => $config->get('custom_filename'), | ||
| '#size' => 60, | ||
| '#maxlength' => 128, | ||
| '#pattern' => '[A-Za-z0-9\-_]+', |
Member
There was a problem hiding this comment.
It would be good to consider non-English characters here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.