Skip to content

fix closing self.open_spi_handles #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lff5 wants to merge 1 commit into
base: pigpio
Choose a base branch
from
Open

fix closing self.open_spi_handles #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pipyadc/pipyadc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def stop(self):
def stop_close_all(self):
"""Close all open pigpio SPI handles and stop pigpio connection
"""
for handle in reversed(self.open_spi_handles):
for handle in reversed(list(self.open_spi_handles.values())):
Copy link
Owner

@ul-gh ul-gh Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume that even before Python 3.6, the reversed() built-in-function would work without turning the dict.values() (or, rather dict.keys()) iterator into a list first.

Can you please check if the following works:
for handle in reversed(self.open_spi_handles.keys()):

logger.debug(f"Closing SPI handle: {handle}")
self.pi.spi_close(handle)
self.open_spi_handles.clear()
Expand Down