Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct return type of document.getElementById from HTMLElement | null to Element | null to account for more general situations like SVGElement #65

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

uhyo
Copy link
Owner

@uhyo uhyo commented Mar 4, 2025

fixes #63

Note: this work was done by Cline with Claude 3.7 except for the changes in build/logic/generate.ts. It cost me $1.2986.

uhyo added 2 commits March 4, 2025 23:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…nt | null` to `Element | null` to account for more general situations like `SVGElement`
@uhyo uhyo merged commit d4a80c2 into master Mar 4, 2025
1 check passed
@uhyo uhyo deleted the fix-63 branch March 4, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] document.getElementById is not correctly typed in TypeScript
1 participant