-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(link): fixes links with marks #6078
base: develop
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 64c8d99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me
Hey @GormanDesign can we have a changeset here? :) |
The linter failed, @GormanDesign could you look into this? |
Changes Overview
The current logic always uses the event.target as the link, but when marks are present the event.target is the mark itself (ie , ). The change below uses the els array to find and assign the link instead of relying on the event.target
Implementation Approach
Testing Done
Tested in application with dynamic user content.
Verification Steps
Manually verification and Cypress tests run in application.
Checklist
Related Issues
#4777