Added L2-norm atom #138
Merged
Added L2-norm atom #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Collaborator
|
Thanks for making this PR @alexahuxn. Could you get your tests to pass the CI? Then I will take a look at the code. |
Contributor
Author
Thank you. I fixed the issue and passed the CI. |
pratikrathore8
requested changes
Dec 10, 2025
rlaopt/atoms/l2_norm.py
Outdated
| lam = scaling * prox_scaling | ||
|
|
||
| def prox_l2(x: torch.Tensor) -> torch.Tensor: | ||
| norm = torch.linalg.norm(x, ord=2) |
Collaborator
There was a problem hiding this comment.
Checking equality for 0 could be unsafe. Could you tweak your implementation to use the compact form at the bottom of pg. 143 in this book: https://www.jacobaguirre.com/First%20Order%20Methods%20in%20Optimization.pdf?
|
pratikrathore8
approved these changes
Dec 11, 2025
Collaborator
pratikrathore8
left a comment
pratikrathore8
left a comment
There was a problem hiding this comment.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added L2-norm atom #131