Add inexact ADMM based on GeNIOS, add classes for solver results #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t being in the affine constraints, and vice versa
zfrangella
previously approved these changes
Dec 5, 2025
Contributor
zfrangella
left a comment
zfrangella
left a comment
There was a problem hiding this comment.
ADMM looks good to me and your hitting everything the tests, so I'm approving.
This was
linked to
issues
Dec 6, 2025
Closed
Closed
PTNobel
previously approved these changes
Dec 7, 2025
pratikrathore8
dismissed stale reviews from PTNobel and zfrangella
via
52fb5b4
zfrangella
approved these changes
Dec 7, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added inexact ADMM based on GeNIOS. Adding this method required refactoring
PCGto use an internal_PCGclass that takes in a fixedPreconditioner.Added classes for solver results, such as
PCGResult,ProxGradResult, andADMMResult. Thesolvemethods now return one of these result classes.Added an option called
detachto solvers, which is set toTrueby default. This option lets the user select whether or not they want the solver to retain the computational graph. Setting this option toFalsestill allows for differentiation through the optimizer.Made linear systems and preconditioners compatible with linear operators.
Incorporated
ADMMand associated classes into docs.Configured bibliography in docs.