Skip to content

fix: resolve Node 22 websocket crash and expose local dev server (#1) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hackerharsh016 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve Node 22 websocket crash and expose local dev server (#1) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions test-error.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
const { chromium } = require('playwright');
(async () => {
const browser = await chromium.launch();
const context = await browser.newContext({ ignoreHTTPSErrors: true });
const page = await context.newPage();
page.on('console', msg => console.log('BROWSER LOG:', msg.type(), msg.text()));
page.on('pageerror', err => console.log('BROWSER ERROR:', err.message));
await page.goto('https://localhost:5173', { waitUntil: 'networkidle' }).catch(e => console.log('Navigation Error:', e));
await page.waitForTimeout(3000);
await browser.close();
})();
8 changes: 8 additions & 0 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ function iGunWSServer() {
configureServer(server: any) {
if (!server.httpServer) return;

// Fix for Node.js 22.21.0 http2 regression with WebSockets
if (typeof server.httpServer.shouldUpgradeCallback !== 'function') {
server.httpServer.shouldUpgradeCallback = () => true;
}

const wss = new WebSocketServer({ noServer: true });
const sessions = new Map();

Expand Down Expand Up @@ -112,5 +117,8 @@ export default defineConfig({
plugins: [react(), tailwindcss(), basicSsl(), iGunWSServer()],
define: {
'__LOCAL_IP__': JSON.stringify(getLocalIp()),
},
server: {
host: true,
}
})