Gm updates #739
Open
Gm updates #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great to me, Alex! I've asked pvp about it. Once we have the summaries for the past GMs, we can go ahead and merge it. |
|
Ready to be merged when we add summaries to each of the past GMs in the google sheets |
yeadamk
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GM Data is now parsed through google sheets (link). New JSON sheet is created to store data for past GMs in 'past-gm.json'. Past GMs have the season, date, banner, and slides displayed (and recording if available). Furthermore, minor bugs on the GM page are fixed- some key errors with JSON mapping as well as border on the map is removed.
Fixes issue #737
How Has This Been Tested?
npm run build -> npm start
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Deploy