Skip to content

Add pytest benchmarking extension#3

Open
EricPedley wants to merge 4 commits intomainfrom
benchmarking
Open

Add pytest benchmarking extension#3
EricPedley wants to merge 4 commits intomainfrom
benchmarking

Conversation

@EricPedley
Copy link
Member

This lets us view the time it took to complete certain function calls. Activating the benchmarks doesn't require anything besides installing the extension and running the tests normally, and the output looks like this:
image

@EricPedley EricPedley requested a review from Vince-C156 July 29, 2023 05:45
Copy link
Contributor

@Vince-C156 Vince-C156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering this is solely for unit testing, maybe all the requirements should be within a single requirements.txt. Also for the statistics in the screenshots you provided please add to the readme how you got these statistics and the machine you ran it on. It would be a good idea for these specs to displayed after every test. I was also not able to successfully run the test script without errors. I installed both requirements.txt and requirements-test.txt.
Screenshot from 2023-07-29 15-13-38
t depending on whos running it.

@EricPedley
Copy link
Member Author

Considering this is solely for unit testing, maybe all the requirements should be within a single requirements.txt

The reason I put the normal requirements and testing tools in different requirements files is to enable us to download only the necessary dependencies when we put code on the drone. But, after explicitly stating that, I now think that we would want to run the tests on the drone anyways so I'll move them to a single file.

@EricPedley
Copy link
Member Author

Also for the statistics in the screenshots you provided please add to the readme how you got these statistics and the machine you ran it on

Good point, we should be documenting exactly what systems we've got this working on. I added a line on the project root README about this.

@EricPedley EricPedley requested a review from Vince-C156 July 30, 2023 20:09
@Vince-C156
Copy link
Contributor

Failed tests not merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants