Open
Conversation
…ey correspond to an image id
…vf_2025 into eric/image-logging-ids
Contributor
|
I feel like its always risky merging stuff in when the first time it will be tested will literally be competition. What do we gain from this PR thats worth the risk? |
Member
Author
|
It cleans up our logs, so you're right it doesn't really help us for competition. I guess you could leave this open until after then merge it in to have it in place when you copy stuff to next year's repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This supercedes #235 and makes logging even cleaner. I forgot to open the PR this morning so it didn't get tested at OCMA.