Draft
Conversation
Member
Author
|
Also before we merge this we gotta ping everyone on Discord to do the steps I outline in the PR to get |
Member
Author
|
I'm too lazy to fix all 80 mypy errors and add the github actions integration. For anyone not following the discord thread, basically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds automatically enforced type checking using
ty. To set up the tool everyone needs to:curl -LsSf https://astral.sh/uv/install.sh | shuv tool install ty@latestuv tool update-shelltyvscode extension by AstralI added settings to our
.vscodethat will disable the errors from Pylance so you only see the ones fromty.tyis an experimental tool but it promises to be super fast so that's why we're trying it. It was very easy to set up for me and I haven't encountered any problems yet. Another reason I chose it was because it's made by Astral and I like the other tools they make.Test Plan
Try committing something like
a: int = 'hi'and it should stop you. Try committing actual working code and it should work like normal.