Issue/676 improve developer experience #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HandcartCactus
requested review from
Thetwam,
bennettscience and
jonespm
as code owners
|
@bennettscience do you have a moment to review this request? |
|
I should have looked more carefully - your imports need to be sorted alphabetically on line 3, so Follow the contributing guide so you run all the applicable style checks before committing again to avoid a build failure. |
|
My apologies. My code is now passing the code-style checks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #677 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 74 74
Lines 3761 3764 +3
=========================================
+ Hits 3761 3764 +3 ☔ View full report in Codecov by Sentry. |
bennettscience
previously approved these changes
Dec 27, 2024
|
This all looks good to me. Tests ran locally, updated the Authors and Changelog. |
bennettscience
approved these changes
Dec 27, 2024
Thetwam
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #676 part 1.
See this comment for screenshots of the result.