Issue/619 Improve new quizzes & graphql requester #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubricAssessments are created against a RubricAssociation object instead of the Rubric. Moving the create method for the RubricAssessment more closely follows the API spec.
RubricAssociations are done in the `Course` module (lines 545 - 566) instead of on the `Rubric` itelf, so it can be removed.
RubricAssessments are created against a RubricAssociation object instead of the Rubric. Moving the create method for the RubricAssessment more closely follows the API spec.
RubricAssociations are done in the `Course` module (lines 545 - 566) instead of on the `Rubric` itelf, so it can be removed.
Updated docstring with class arguments Add check for _url without breaking `full_url` assignment See ucfopen#619 for more details. Following discussion on ucfopen#619, let the `Requester` be smarter about how to send a request. The user can specify either `new_quizzes` or `graphql` in the request to automatically use the correct endpoint. This moves repeated logic out of the class methods themselves.
Handle the new quizzes endpoint on the Requester instance if the _url kwarg is set to "new_quizzes." Tests passing for new quizzes, quizzes, and requester. Course tests are failing because of the way Paginated Lists handle URL overrides...more work to do on that module.
Based on ucfopen#612 and as an issue in ucfopen#619, this adds the `new_quizzes` and `graphql` keyword endpoints in the requester module. Methods which specify these locations will have the correct URL supplied by the library in the `_url` parameter for the requester.
|
Closing because I need to clean up my commit history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add a
new_quizzesandgraphqlkeyword to theRequesterinstance to handle special API endpoints.Fixes #619.